-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enhance the webpack-encore integration #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -5,6 +5,11 @@ Encore | |||
.setPublicPath('/build') | |||
.cleanupOutputBeforeBuild() | |||
.autoProvidejQuery() | |||
.autoProvideVariables({ | |||
"window.jQuery": "jquery", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a PR on webpack-encore to provide this automatically
Thanks a lot for working on this! I've tested your PR in the page where most JS is used (
However, the following doesn't work yet:
|
Yes I notice that the code don't get highlight colors, I'm working on it.
|
@javiereguiluz all issues have been addressed |
I've reviewed your latest changes. Everything is indeed fixed. Thanks a lot! Now I have 3 comments:
If "import" is the way to go, we should update Encore docs too.
|
1/ As we are in ES6 syntax we can use |
@javiereguiluz AFAIK the expected autocomplete list will be all available tags (used or not) and you can also insert new ones (typing it there +
I'm not sure what do you mean? |
@alOneh I've tested your last changes and everything is great! To me this PR is now ready to be merged. The only optional change I'd like to do is to get rid of the moment.js library. It's humongous and it makes our admin.js to weight almost 400 KB 😱 @yceruto never mind, let's keep it as is and we'll tweak it in the future if needed. Thanks! |
@alOneh does moment has a way to skip the import of the part loading locales dynamically, as you did for highlight.js ? This would avoid bundling all moment locales if we don't need them. |
Tested again and it works perfectly. This is now finished, so I'm merging it and later, if needed, @weaverryan can make any tweak to this config before releasing the new version of the Symfony Demo. Thanks @alOneh! |
@javiereguiluz I don't push build files ! |
This enhance the first integration (#586) of webpack-encore.
Fixes :